Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI - Remove lint from CI #1856

Merged
merged 3 commits into from
Jun 4, 2024
Merged

CI - Remove lint from CI #1856

merged 3 commits into from
Jun 4, 2024

Conversation

trallard
Copy link
Collaborator

@trallard trallard commented Jun 4, 2024

This removes the lint step in our CI so that we only use pre-commit CI as our default linting/formatter for contibutions and avoid frustrations.

@trallard trallard requested review from Carreau and drammock June 4, 2024 12:13
@trallard trallard added the tag: CI Pull requests that update GitHub Actions code label Jun 4, 2024
drammock
drammock approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. My hope is that we can add this back at some point, because I like the idea of saving CI cycles if linting isn't right. But for now I just need the CIs to actually run :)

@drammock drammock merged commit 97e60ba into pydata:main Jun 4, 2024
29 checks passed
@trallard trallard deleted the trallard/update-pre-commit branch June 4, 2024 16:49
@drammock drammock mentioned this pull request Jun 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drammock drammock drammock approved these changes

@Carreau Carreau Awaiting requested review from Carreau

Assignees
No one assigned
Labels
tag: CI Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trallard @drammock